Merging Github patches Topic is solved

Section with modification and patches for Vesta
phre4k
Posts: 6
Joined: Mon Feb 29, 2016 12:27 pm

Merging Github patches

Postby phre4k » Mon Feb 29, 2016 12:34 pm

Hey guys,

We have a discussion about maintainers of the github repo here:
https://github.com/serghey-rodin/vesta/issues/641

It'd be very nice if Serghey could destine some github users for merging code into a dev branch of the software, since a lot of the PRs (currently 53 and rising!) pile up and nobody merges them.

skurudo
VestaCP Team
Posts: 7802
Joined: Fri Dec 26, 2014 2:23 pm
Location: Moscow
Contact:

Re: Merging Github patches  Topic is solved

Postby skurudo » Mon Feb 29, 2016 2:45 pm

Thanks for the offer. Serghey aware of the situation, I think that in the near future it will.
Now merge code little sense, since serious refactoring...
-> DigitalOcean competition - please, support us
-> fix for phpmyadmin - nice and sweet now

phre4k
Posts: 6
Joined: Mon Feb 29, 2016 12:27 pm

Re: Merging Github patches

Postby phre4k » Tue Mar 01, 2016 6:54 pm

Any ETA on the rewrite? Why is this not done via github branch? :)

imperio
VestaCP Team
Posts: 5567
Joined: Sat Dec 01, 2012 12:37 pm
Contact:

Re: Merging Github patches

Postby imperio » Tue Mar 01, 2016 7:04 pm

Hi,
Now we are rewriting all vestacp code, so you cant see some changes in the github. When the refactoring will be done, we will publish it on the github repository.
-> DigitalOcean competition - please, support us
-> fix for phpmyadmin - nice and sweet now

phre4k
Posts: 6
Joined: Mon Feb 29, 2016 12:27 pm

Re: Merging Github patches

Postby phre4k » Thu Mar 03, 2016 11:41 am

Yes, I understood that.

However, I think developing "in the dark" is not the best idea for the future of VestaCP (after the rewrite).

You can create an "alpha" or "beta" branch on github which differs from the master branch and is for rewriting existing code which doesn't land in production. This could also be a test bed for contributions by other people on github so they can be tested and don't land in the master branch immediately.

You could also leverage the tags and releases from github to make the whole development process more streamlined. What do you think about that? At the moment the github repository and development process is pretty suboptimal, in my opinion.

imperio
VestaCP Team
Posts: 5567
Joined: Sat Dec 01, 2012 12:37 pm
Contact:

Re: Merging Github patches

Postby imperio » Thu Mar 03, 2016 11:52 am

We will think about it. Thank you for your suggestion.
-> DigitalOcean competition - please, support us
-> fix for phpmyadmin - nice and sweet now

phre4k
Posts: 6
Joined: Mon Feb 29, 2016 12:27 pm

Re: Merging Github patches

Postby phre4k » Tue Mar 08, 2016 6:53 pm

imperio wrote:We will think about it. Thank you for your suggestion.

Nice to hear you're considering this!

I'm eager to test it when it's out. Good luck :)


Return to “Modification & Patches”



Who is online

Users browsing this forum: No registered users and 2 guests