There is a bug in WHMCS modules

[FirstVM.com]

While integrate vestacp to WHMCS, I found there was a bug in vesta.php module.

please see the image:



it was " $serverhostname" here.
but it shoud be : $params[‘serverhostname’]

otherwise, the customer was not able to login webmail from his client area.

[heihachi88]

Indeed, Skid, fix this please.

[zeeshan030]

otherwise, the customer was not able to login webmail from his client area.

___________________
developments
Littlelioness
Episodes 131-135: The Post-Alabasta Arc

[skurudo]

otherwise, the customer was not able to login webmail from his client area.

Topic quite old, not sure this "bug" still active.
It's a bug? How can we test this? Will you help with this? (sorry, don't have WHMCS)

[TopeZ]

Yes this bug is still active.

I've recently ran into this as well and fixed it myself in the WHMCS VestaCP Module - vesta.php

I however did it differently and used "$params["domain"]" instead.

He's referring to a small section in the Client Area for WHMCS @

Code: Select all

function vesta_ClientArea($params) {

    $code = '<form action="https://'.$params["serverhostname"].':8083/login/" method="post" target="_blank">
<input type="hidden" name="user" value="'.$params["username"].'" />
<input type="hidden" name="password" value="'.$params["password"].'" />
<input type="submit" value="Login to Control Panel" />
<input type="button" value="Login to Webmail" onClick="window.open(\'http://'.$serverhostname.'/webmail\')" />
</form>';
    return $code;

This portion:

Code: Select all

<input type="button" value="Login to Webmail" onClick="window.open(\'http://'.$serverhostname.'/webmail\')" />

Should actually be:

Code: Select all

<input type="button" value="Login to Webmail" onClick="window.open(\'http://'.$params["domain"].'/webmail\')" />

Simple quick fix, nothing big.