Page 1 of 1

Merging Github patches

Posted: Mon Feb 29, 2016 12:34 pm
by phre4k
Hey guys,

We have a discussion about maintainers of the github repo here:
https://github.com/serghey-rodin/vesta/issues/641

It'd be very nice if Serghey could destine some github users for merging code into a dev branch of the software, since a lot of the PRs (currently 53 and rising!) pile up and nobody merges them.

Re: Merging Github patches

Posted: Mon Feb 29, 2016 2:45 pm
by skurudo
Thanks for the offer. Serghey aware of the situation, I think that in the near future it will.
Now merge code little sense, since serious refactoring...

Re: Merging Github patches

Posted: Tue Mar 01, 2016 6:54 pm
by phre4k
Any ETA on the rewrite? Why is this not done via github branch? :)

Re: Merging Github patches

Posted: Tue Mar 01, 2016 7:04 pm
by imperio
Hi,
Now we are rewriting all vestacp code, so you cant see some changes in the github. When the refactoring will be done, we will publish it on the github repository.

Re: Merging Github patches

Posted: Thu Mar 03, 2016 11:41 am
by phre4k
Yes, I understood that.

However, I think developing "in the dark" is not the best idea for the future of VestaCP (after the rewrite).

You can create an "alpha" or "beta" branch on github which differs from the master branch and is for rewriting existing code which doesn't land in production. This could also be a test bed for contributions by other people on github so they can be tested and don't land in the master branch immediately.

You could also leverage the tags and releases from github to make the whole development process more streamlined. What do you think about that? At the moment the github repository and development process is pretty suboptimal, in my opinion.

Re: Merging Github patches

Posted: Thu Mar 03, 2016 11:52 am
by imperio
We will think about it. Thank you for your suggestion.

Re: Merging Github patches

Posted: Tue Mar 08, 2016 6:53 pm
by phre4k
imperio wrote:We will think about it. Thank you for your suggestion.
Nice to hear you're considering this!

I'm eager to test it when it's out. Good luck :)

Re: Merging Github patches

Posted: Wed Feb 14, 2018 9:04 am
by skurudo
Closed due inactivity.