BUG: %backend% interpreted as empty after upgrade to 0.9.8-16

[Clouseau]

Hello,

I upgraded from 0.9.8-15 to latest (I did yum update and that is it) and all was good. But today I noticed that if I reselect php-fpm backend template in Vesta gui it gets written in /etc/php-fpm.d/.conf - it is missing the part before .conf. And it is not working with that. Also the part in /var/run/php5-.conf is written. The content of /etc/php-fpm.d/.conf is this, I deleted not important parts:

Code: Select all

hostname php-fpm.d # cat .conf 
[]
listen = /var/run/php5-.sock

pm.status_path = /status

slowlog = /var/log/php-fpm/-slow.log

Any idea? Here is the content of the php-fpm template:

Code: Select all

[%backend%]
listen = /var/run/php5-%backend%.sock
listen.allowed_clients = 127.0.0.1

user = %user%
group = %user%

listen.owner = %user%
listen.group = nginx

pm = dynamic
pm.max_children = 8
pm.start_servers = 4
pm.min_spare_servers = 2
pm.max_spare_servers = 5
pm.max_requests = 0

slowlog = /var/log/php-fpm/%backend%-slow.log

php_admin_value[error_log] = /var/log/php-fpm/%backend%-error.log

The %backend% variable is not set obviously?

[Clouseau]

If I run v-rebuild-user username in cli after modification of template, then the configs are properly updated.

Nevertheless, if I switch to Socket in php-fpm backeng in GUI, the .conf is created. This is a bug in Vesta GUI panel, this was not present in 0.9.8-15 version.

[Clouseau]

Just did a fresh install on new server. The behaviour is the same, just switch in GUI from default to socket in backend php-fpm template and it is broken, %backlend% is not set in config files...

[skurudo]

You can try use this fix:
https://github.com/serghey-rodin/vesta/ ... cc2f9bce01

https://bugs.vestacp.com/issues/273 and related
https://bugs.vestacp.com/issues/347
https://bugs.vestacp.com/issues/350

[Clouseau]

Hi. But that is allready present in 0.9.8-16 installation. If you freshly install it on CentOS you have this so I do not now for what is that commit?

50 prepare_web_backend
51 rm -f $pool/$backend_type.conf
52 else
53 for domain in $($BIN/v-list-web-domains $user plain |cut -f 1); do
54 prepare_web_backend
55 rm -f $pool/$backend_type.conf
56 done
57 fi
58 fi
59
60 # Starting rebuild loop for each web domain
61 for domain in $($BIN/v-list-web-domains $user plain |cut -f 1); do
62 if [ ! -z "$WEB_BACKEND" ]; then
63 template=$(get_object_value 'web' 'DOMAIN' "$domain" '$BACKEND')
64 $BIN/v-add-web-domain-backend $user $domain $template
65 fi
66 rebuild_web_domain_conf
67 done

[Clouseau]

To sum up, this is present in GUI of Vesta panel. I presume the problems are somewhere in:

v-change-web-domain-tpl
v-change-web-domain-backend-tpl

Becuse if you change it through GUI, it messes up the files, writes ".conf" missing the part berfore .conf. And that same part is missing from nginx conf.

v-rebuil-user fixes the problem.

The problem is not present on first creation of domain, it is present when you wanna change the web domain tpl and web-domain-backend-tpl